[iOS] Remove undefined references to OCMock from RNTesters' pbxproj#39616
Closed
Saadnajmi wants to merge 1 commit into
Closed
[iOS] Remove undefined references to OCMock from RNTesters' pbxproj#39616Saadnajmi wants to merge 1 commit into
Saadnajmi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Saadnajmi
commented
Sep 22, 2023
Comment on lines
-969
to
+940
| "-DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1", | ||
| "-DFOLLY_USE_LIBCPP=1", | ||
| "-DFOLLY_CFG_NO_COROUTINES=1", |
Contributor
Author
There was a problem hiding this comment.
I left these in because it happens every time I run pod install and seems to be mostly formatting.
facebook-github-bot
added
the
Shared with Meta
Base commit: 0f2ecd3 |
Contributor
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In #36239 , I removed the copy of libOCMock we had locally in favor of a Pod. The references were left in RNTester's pbxproj and undefined. Let's just remove them.
Changelog:
[INTERNAL] [FIXED] - Remove undefined references to OCMock from RNTesters' pbxproj
Test Plan:
CI should pass